Skip to content

Extract tracker module #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gthea merged 21 commits into from
Apr 23, 2026

Add tests for TelemetryEventQueueStats and Event.equals(), add no-op …

257fe7f
Select commit
Loading
Failed to load commit list.
Merged

Extract tracker module #624

Add tests for TelemetryEventQueueStats and Event.equals(), add no-op …
257fe7f
Select commit
Loading
Failed to load commit list.
SonarQube Pull Requests / SonarQube Code Analysis succeeded Apr 22, 2026 in 51s

Quality Gate passed

Issues
42 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Annotations

Check warning on line 18 in tracker/src/test/java/io/split/client/events/EventsTaskTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Rename this field "_storage" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

[S116] Field names should comply with a naming convention
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=b87cec13-e7a8-4228-bed0-77e9f9a4e6a6&open=b87cec13-e7a8-4228-bed0-77e9f9a4e6a6

Check warning on line 140 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertNotEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=25b5e723-c836-43f2-8047-9cec9eed930d&open=25b5e723-c836-43f2-8047-9cec9eed930d

Check warning on line 202 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=57fd70ac-46d1-4cb4-9c5b-0b68a19d934a&open=57fd70ac-46d1-4cb4-9c5b-0b68a19d934a

Check warning on line 231 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=36a3ee8b-95ac-4c25-873f-c0ae081a5c77&open=36a3ee8b-95ac-4c25-873f-c0ae081a5c77

Check warning on line 18 in tracker/src/main/java/io/split/client/events/InMemoryEventsStorage.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Rename this field "_stats" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

[S116] Field names should comply with a naming convention
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=e3db1149-2d2f-40c8-8549-100a960db499&open=e3db1149-2d2f-40c8-8549-100a960db499

Check warning on line 21 in tracker/src/main/java/io/split/client/events/EventsTask.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Rename this field "_eventsSender" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

[S116] Field names should comply with a naming convention
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=95beae39-a368-43da-8541-f39573e21a9c&open=95beae39-a368-43da-8541-f39573e21a9c

Check warning on line 500 in client/src/test/java/io/split/engine/experiments/RuleBasedSegmentParserTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=d4a52955-ccbd-4ffd-b245-b77d21139d5a&open=d4a52955-ccbd-4ffd-b245-b77d21139d5a

Check warning on line 20 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertNotEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=3dc7fde6-4f90-4cb4-907a-b89a59e9c810&open=3dc7fde6-4f90-4cb4-907a-b89a59e9c810

Check warning on line 608 in client/src/test/java/io/split/engine/experiments/SplitParserTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=6dd449ad-650e-4dd9-9b95-1e2221a121e2&open=6dd449ad-650e-4dd9-9b95-1e2221a121e2

Check warning on line 203 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=8ecbaca8-5f35-485b-b90a-2e27f765c097&open=8ecbaca8-5f35-485b-b90a-2e27f765c097

Check warning on line 478 in client/src/test/java/io/split/engine/experiments/RuleBasedSegmentParserTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=a18d95fc-0120-4d50-afcb-0a53d1afca21&open=a18d95fc-0120-4d50-afcb-0a53d1afca21

Check warning on line 14 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=bffc1256-026e-4a6c-8eda-98524bbc891e&open=bffc1256-026e-4a6c-8eda-98524bbc891e

Check warning on line 102 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertNotEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=af6d2ca2-dc2f-4eb3-a35a-401e4031eb26&open=af6d2ca2-dc2f-4eb3-a35a-401e4031eb26

Check warning on line 140 in client/src/main/java/io/split/client/SplitFactoryImpl.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Split this “Monster Class” into smaller and more specialized ones to reduce its dependencies on other classes from 30 to the maximum authorized 20 or less. 

[S6539] Classes should not depend on an excessive number of classes (aka Monster Class)
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=2f22ea05-bc0e-4f3e-830c-83ef6784c307&open=2f22ea05-bc0e-4f3e-830c-83ef6784c307

Check warning on line 434 in client/src/test/java/io/split/engine/experiments/RuleBasedSegmentParserTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=a904777c-0034-454f-81d8-e1abdd9305aa&open=a904777c-0034-454f-81d8-e1abdd9305aa

Check warning on line 10 in client/src/main/java/io/split/client/events/TelemetryEventQueueStats.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Rename this field "_telemetryRuntimeProducer" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

[S116] Field names should comply with a naming convention
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=17ee5f3d-9d8f-48b5-83cc-d93fb3f75e3a&open=17ee5f3d-9d8f-48b5-83cc-d93fb3f75e3a

Check warning on line 229 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=d593f0cf-5e23-4474-933a-21125720b7c2&open=d593f0cf-5e23-4474-933a-21125720b7c2

Check warning on line 230 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=3b5490db-f8f2-468c-b05a-28fc99be77dc&open=3b5490db-f8f2-468c-b05a-28fc99be77dc

Check warning on line 112 in client/src/test/java/io/split/engine/matchers/SemverTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=ffecbfec-fffc-41e5-a079-699fbe31e9f0&open=ffecbfec-fffc-41e5-a079-699fbe31e9f0

Check warning on line 20 in tracker/src/test/java/io/split/client/events/EventsTaskTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Rename this field "_task" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

[S116] Field names should comply with a naming convention
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=c005243e-d081-45b6-b631-0600253cbfb4&open=c005243e-d081-45b6-b631-0600253cbfb4

Check warning on line 586 in client/src/test/java/io/split/engine/experiments/SplitParserTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=70654119-2589-46f7-a826-365ff82b2ee1&open=70654119-2589-46f7-a826-365ff82b2ee1

Check warning on line 183 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=24513df7-2efc-4cd5-a7a7-7b9d2e6438e1&open=24513df7-2efc-4cd5-a7a7-7b9d2e6438e1

Check warning on line 16 in tracker/src/test/java/io/split/client/events/InMemoryEventsStorageTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Rename this field "_storage" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

[S116] Field names should comply with a naming convention
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=0ca0c77b-01ad-4242-93f1-9e74ea0e3ceb&open=0ca0c77b-01ad-4242-93f1-9e74ea0e3ceb

Check warning on line 111 in client/src/test/java/io/split/engine/matchers/SemverTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=28bfd3c2-ceb1-48c7-bcfb-3c84faebcd73&open=28bfd3c2-ceb1-48c7-bcfb-3c84faebcd73

Check warning on line 163 in tracker/src/test/java/io/split/client/dtos/EventTest.java

See this annotation in the file changed.

@sonarqube-pull-requests sonarqube-pull-requests / SonarQube Code Analysis

Use assertEquals instead. 

[S5785] JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion
 See more on https://sonar.harness.io/project/issues?id=io.split.client%3Ajava-client-parent&pullRequest=624&issues=c1d2e769-e38d-497b-a617-a2a26407d451&open=c1d2e769-e38d-497b-a617-a2a26407d451
View more details on SonarQube Pull Requests