Added retry logic & batching settings by shakeelmohamed · Pull Request #1 · splunk/splunk-javascript-logging

shakeelmohamed · 2015-11-10T00:03:40Z

No description provided.

The incorrect index error will only happen if an token is locked down to a specific index(es).

Specify the max number of retries when configuring a logger. The maximum backoff (time between retries) is capped at 2 minutes.

Also updated tests.

When this many events are in the contextQueue, flush() will be called.

itay · 2015-11-10T00:43:49Z

splunklogger.js

Why do you need to do this?

If _enableTimer(interval) is called explicitly, we just store that interval value in the config. It could be removed

itay · 2015-11-10T01:02:40Z

splunklogger.js

I also don't get this case here. Why do you distinguish between batch and unbatched?

For isBatched we empty the entire queue, otherwise 1 event per request

I understand what you're doing, I just don't understand why you're doing it. Why are you making a distinction here?

geloizi · 2015-11-10T15:44:47Z

splunklogger.js

what measurement units do you use here? Milliseconds?

TODO: - Make some decisions about middleware - Update remaining examples - Add a few timer tests for 100% coverage - Added ability to have custom event formatter - Context no longer has config or requestOptions - If !autoflush and any batching settings, throw an error - Simplified logic in many places - Added several util functions - Updated tests - Clarified the basic.js example

All batch settings will be ignored when they are <= 0.

Added remaining tests for utils

We have collectively decided that this feature does not provide enough value at this time.

itay · 2015-11-16T22:12:02Z

examples/basic.js

Why do you need to set this?

If none of the batch settings are configured, and autoFlush === true (the default) it's basically not manual batching

itay · 2015-11-16T22:24:39Z

splunklogger.js

Why do you need contextQueue? This could easily be just an incremented number. You're storing a lot more memory this way.

simplified, done

This change optimizes the flush() function since events will only be serialized once after passed to send(). Without middleware, we no longer need to store un-serialized objects.

To disable autoFlush behavior, set all batching settings to 0. It is still enabled by default - flushing events 1 by 1. Modify this behavior through the config object.

shakeelmohamed · 2015-11-17T05:06:21Z

Closing this PR, opening another one with updated readme, examples and version numbers.

Shakeel Mohamed added 15 commits September 30, 2015 16:25

Update tests to pass with a default token

fa8a3ef

The incorrect index error will only happen if an token is locked down to a specific index(es).

Add utils.whilst + tests, rename utils.chain tests

ae08451

Add utils.expBackoff for exponential backoff timeout

1a55810

Add retry on error logic, via exponential backoff.

76e3a43

Specify the max number of retries when configuring a logger. The maximum backoff (time between retries) is capped at 2 minutes.

Merge branch 'develop' into feature/retry

e2d9342

Add retry example & update readme

2042e05

Update examples

3f4f3bd

Add support for automatic interval batching.

d598fb0

Clean up batch interval implementation

3870937

Add another config test for autoflush

fc98ed9

Update doc datatype for batch interval

566c3cb

Add configuration setting for batch size

fa7f3b6

Moved complicated logic from _sendEvents() to flush()

e5ded8d

Also updated tests.

Optimize calculateBatchSize, add additional test coverage

2f4bb81

Add configuration setting for batch count

806b220

When this many events are in the contextQueue, flush() will be called.

itay reviewed Nov 10, 2015
View reviewed changes

Add comments to timer initialization logic

bdc30ac

itay reviewed Nov 10, 2015
View reviewed changes

geloizi reviewed Nov 10, 2015
View reviewed changes

Shakeel Mohamed added 9 commits November 13, 2015 14:08

Add units for _enableTimer()

d50f1bd

Disable maxBatchSize and maxBatchCount by default.

ae5d79b

All batch settings will be ignored when they are <= 0.

Rename utils.validatePositiveInt() to validateNonNegativeInt()

331143c

Added remaining tests for utils

Renamed batching example to manual_batching

974187f

Add all batching settings example

d50f926

remove middleware and all references to it

0644497

We have collectively decided that this feature does not provide enough value at this time.

Update tests for 100% coverage

bd45dfa

Added new example for custom event format

1a0c5bb

itay reviewed Nov 16, 2015
View reviewed changes

Shakeel Mohamed added 2 commits November 16, 2015 14:22

Correct the payload comment in the basic example

d9ce2d6

Correct comment in all batching example

e2f9881

itay reviewed Nov 16, 2015
View reviewed changes

Shakeel Mohamed added 3 commits November 16, 2015 16:06

Refactor contextQueue to serializedContextQueue

8fa15ab

This change optimizes the flush() function since events will only be serialized once after passed to send(). Without middleware, we no longer need to store un-serialized objects.

Remove the config.autoFlush property.

4faf827

To disable autoFlush behavior, set all batching settings to 0. It is still enabled by default - flushing events 1 by 1. Modify this behavior through the config object.

Update examples following refactor

dab006b

shakeelmohamed closed this Nov 17, 2015

shakeelmohamed deleted the feature/batch-event-count branch December 10, 2015 19:09

Conversation

shakeelmohamed commented Nov 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shakeelmohamed commented Nov 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments