External Entities restricted in XML factory.#180
Merged
bparmar-splunk merged 1 commit intodevelopfrom Dec 7, 2021
Merged
Conversation
fantavlik
requested changes
Dec 4, 2021
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Can you provide more context in the PR, instead of describing what was changed it would be useful to know why a change is needed and what the affect will be before and after. This is all useful in the PR itself - assume no one has access to our internal JIRA.
fantavlik
reviewed
Dec 4, 2021
| factory.setExpandEntityReferences(false); | ||
| factory.setFeature("http://xml.org/sax/features/external-parameter-entities", false); | ||
| factory.setFeature("http://xml.org/sax/features/external-general-entities", false); | ||
| factory.setNamespaceAware(false); |
Contributor
There was a problem hiding this comment.
Also let's use https if possible here once I understand the intent of the change
Contributor
Author
There was a problem hiding this comment.
Using https in feature URLs are not available when tests are executed. So all http URLs are correct.
fantavlik
approved these changes
Dec 6, 2021
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Again, thanks for the explanations 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: