Re-fetch instanceType if not provided#202
Merged
ashah-splunk merged 2 commits intodevelopfrom Dec 8, 2022
Merged
Conversation
fantavlik
approved these changes
Nov 30, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
This looks correct to me, thanks for the quick turnaround. Let's confirm with the user reporting this issue before merging but approved from my standpoint.
added check for Host IP address.
Contributor
|
Just updated the PR description but other than that the changes look good - feel free to merge when we have validation |
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.