Feature added to include cluster master hosts for HostName verification#215
Merged
ashah-splunk merged 3 commits intodevelopfrom May 18, 2023
Merged
Feature added to include cluster master hosts for HostName verification#215ashah-splunk merged 3 commits intodevelopfrom
ashah-splunk merged 3 commits intodevelopfrom
Conversation
Contributor
ashah-splunk
commented
May 17, 2023
ashah-splunk
commented
- added instance method in Service class to get list of cluster master hosts
- added static method in HttpService class to update list of Valid Hosts with Cluster Master Hosts
- added instance method in Service class to get list of cluster master hosts - added static method in HttpService class to update list of Valid Hosts
fantavlik
reviewed
May 17, 2023
fantavlik
approved these changes
May 17, 2023
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Nice catch, and clean approach to addressing it
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.