NodeUnit to Mocha Transition for Browser Test Cases#127
Merged
rmaheshwari-splunk merged 5 commits intoDVPL-9114from Jul 19, 2021
Merged
NodeUnit to Mocha Transition for Browser Test Cases#127rmaheshwari-splunk merged 5 commits intoDVPL-9114from
rmaheshwari-splunk merged 5 commits intoDVPL-9114from
Conversation
Test case migration from nodeUnit to Mocha
Css has been fixed.
fantavlik
approved these changes
Jul 16, 2021
Contributor
|
Looks great, does this get us closer to being able to run browser tests in CI @ashah-splunk? That would be really ideal, but even upgrading to a modern test framework is a big improvement - thanks for this. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing nodeUnit test cases have been updated to use Mocha and the existing test file splunk.test.js is replaced by following files which have been added and each file represents test cases based on different functionality.
client/browser_utils.js - This file contains Utils test cases.
client/browser_async.js - This file contains Async test cases.
client/browser_context.js - This file contains Context test cases.
client/browser_service.js - This file contains Service test cases.