Login example and README.md change#138
Merged
ashah-splunk merged 4 commits intodevelopfrom Aug 23, 2021
Merged
Conversation
fantavlik
reviewed
Aug 20, 2021
| ```shell | ||
| #### From shell #### | ||
| # Enable token authetication | ||
| curl -k -u <username>:<password> -X POST <scheme>://<host>:<port>/services/admin/token-auth/tokens_auth -d disabled=false |
Contributor
There was a problem hiding this comment.
I believe /services/admin/token-auth/tokens_auth the admin in this path is necessary so no change needed
fantavlik
reviewed
Aug 20, 2021
README.md
Outdated
| curl -k -u <username>:<password> -X POST <scheme>://<host>:<port>/services/admin/token-auth/tokens_auth -d disabled=false | ||
|
|
||
| # Create a token | ||
| curl -k -u <username>:<password> -X POST <scheme>://<host>:<port>/services/authorization/tokens?output_mode=json --data name=admin --data audience=Users --data-urlencode expires_on=+30d |
Contributor
There was a problem hiding this comment.
Here I think name=admin could refer to any valid username so suggest changing to name=<username> - I just tried this so I think that should be correct
fantavlik
reviewed
Aug 20, 2021
examples/node/login.js
Outdated
| curl -k -u <username>:<password> -X POST <scheme>://<host>:<port>/services/admin/token-auth/tokens_auth -d disabled=false | ||
|
|
||
| Execute following command to create bearer token manually: | ||
| curl -k -u <username>:<password> -X POST <scheme>://<host>:<port>/services/authorization/tokens?output_mode=json --data name=admin --data audience=Users --data-urlencode expires_on=+30d |
Contributor
There was a problem hiding this comment.
Same change here: name=admin -> name=<username>
fantavlik
approved these changes
Aug 20, 2021
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Looking really good, I had a minor correction but feel free to merge once that gets addressed, or feel free to push back if you think I have it incorrect.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.