.conf CRUD functionality added#141
Merged
vmalaviya-splunk merged 11 commits intodevelopfrom Jan 10, 2022
Merged
Conversation
fantavlik
requested changes
Dec 21, 2021
Contributor
There was a problem hiding this comment.
This is looking really close, some minor comments and questions. I wonder if we could provide a simple example of how to use this also? The test has some of this but it would be nice to have just a few lines demonstrating the change (in the README)
1. Method renamed: doesFileExist --> getConfFile 2. Method renamed: doesStanzaExist --> getStanza 3. try/catch removed to let exception propagate to calling method 4. return file/stanza if found or else return null
fantavlik
requested changes
Jan 6, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Two fairly minor comments and then I think this is ready to merge
README and test updated to use actual example for .conf file
fantavlik
approved these changes
Jan 7, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Awesome work, thanks for working through all the rounds of review!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.