Merged
Conversation
Contributor
ashah-splunk
commented
Apr 13, 2022
ashah-splunk
commented
- changes corresponding to API changes in the dependency library browserify. Resolved compilation error
Contributor
|
I'm running into this issue with node 14.19.1: $ rm client/splunk.*
$ node sdkdo compile
Compiled client/splunk.ui.js
Compiled client/splunk.ui.min.js
Compiled client/splunk.ui.timeline.js
Compiled client/splunk.ui.timeline.min.js
Compiled client/splunk.ui.charting.min.js
Compiled client/splunk.ui.charting.js
./splunk-sdk-javascript/bin/cli.js:477
src.toString(),
^
TypeError: Cannot read property 'toString' of undefined
at Readable.<anonymous> (./splunk-sdk-javascript/bin/cli.js:477:33)
at Readable.emit (events.js:400:28)
at Labeled.<anonymous> (./splunk-sdk-javascript/node_modules/read-only-stream/index.js:28:44)
at Labeled.emit (events.js:400:28)
at Labeled.<anonymous> (./splunk-sdk-javascript/node_modules/stream-splicer/index.js:130:18)
at Labeled.emit (events.js:400:28)
at Deps.<anonymous> (./splunk-sdk-javascript/node_modules/stream-splicer/index.js:130:18)
at Deps.emit (events.js:400:28)
at ./splunk-sdk-javascript/node_modules/module-deps/index.js:379:30
at onresolve (./splunk-sdk-javascript/node_modules/module-deps/index.js:181:25)
|
fantavlik
requested changes
Apr 19, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Got it, I was able to get this working after running npm install - can we update the node_modules changes associated with this before merging so that others don't run into the same issue?
fantavlik
approved these changes
Apr 25, 2022
fantavlik
requested changes
Apr 25, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Sorry it looks like the dependency updates may have caused CI issues with testing
fantavlik
approved these changes
Apr 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.