Added 'User-Agent' header in REST API calls for the telemetry#151
Merged
ashah-splunk merged 4 commits intodevelopfrom Apr 29, 2022
Merged
Added 'User-Agent' header in REST API calls for the telemetry#151ashah-splunk merged 4 commits intodevelopfrom
ashah-splunk merged 4 commits intodevelopfrom
Conversation
fantavlik
requested changes
Apr 19, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
This is a good start with the node.js client, I believe these clients also need to follow the same logic for the browser clients to work and we'd like to test to make sure the User-Agent isn't being overwritten by browser information for those scenarios: https://github.com/splunk/splunk-sdk-javascript/tree/master/lib/platform/client
fantavlik
approved these changes
Apr 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index=_internal "splunk-sdk-javascript/1.11.0"to make sure the event appears as expected