Removed examples and it's references from sdk#152
Merged
ashah-splunk merged 6 commits intodevelopfrom May 13, 2022
Merged
Conversation
Contributor
akaila-splunk
commented
Apr 29, 2022
akaila-splunk
commented
- removed example directory
- removed test_examples.js file used for testing example
- removed all example references and updated readme.md file
- added splunk-app-examples repo details in readme.md file
fantavlik
reviewed
May 11, 2022
| @@ -5,7 +5,6 @@ | |||
| "homepage": "http://dev.splunk.com", | |||
| "main": "index.js", | |||
| "directories": { | |||
| "example": "examples", | |||
Contributor
There was a problem hiding this comment.
Did we also do an audit of the dependencies and devDependencies after removing examples? I wonder if there are libraries only being used in the examples that we can remove. That can be done as a followup to this PR also I don't want to block on that.
fantavlik
approved these changes
May 11, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Looks good to merge, I also had a followup question about whether there may be dependencies that are no longer needed in package.json
Contributor
|
@fantavlik as suggested we did a follow up on the dependencies but there are none that are used only for examples. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.