Remove unchecked splunk restart in test_modular_input_kinds.py#652
Merged
mateusz834 merged 1 commit intodevelopfrom Aug 26, 2025
Merged
Conversation
These do not seem to be necessary, install_app_from_collection internally handles restarting of splunk. Also other tests that call install_app_from_collection do not restart splunk before.
mateusz834
force-pushed
the
dev/MP/remove-unchecked-restart-in-modular-input-tests
branch
from
70e520c to
8e0a4ba
Compare
Ickerday
approved these changes
Aug 25, 2025
mateusz834
deleted the
dev/MP/remove-unchecked-restart-in-modular-input-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These do not seem to be necessary,
install_app_from_collectioninternally handles restarting of splunk. Also other tests that callinstall_app_from_collectiondo not restart splunk before.