This repository was archived by the owner on Aug 12, 2024. It is now read-only.
Use LookupSession for async lookups#46
Closed
ibauersachs wants to merge 1 commit into
Closed
Conversation
|
@ibauersachs thanks! We will look through this and switch to |
Collaborator
|
Hi @ibauersachs we opened a new PR for this change which backwards compatible changes #47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@klaraward This is a rather naive attempt at refactoring this project to use dnsjava's
LookupSession. See the discussion in dnsjava/dnsjava#211. It breaks some API which probably shouldn't be public anyway, needs further refactoring because e.g.LookupFactorydoesn't make sense anymore (because LookupSession is thread-safe), and the unit tests need some work (e.g. move to JUnit 5).