Java properties are not passed to forked task

[labianchin]

With the introduction of ForkingExecutor, I started noticing some errors on BQ flo tasks.

It seems to be related to the fact that I am running the flo process with -DGOOGLE_CLOUD_PROJECT=my-gcp-project and that system property definition is not passed to the the forked task subprocess.

To fix that would require some changes on ForkingExecutor, I guess something related to this.

[danielnorberg]

I remember writing the code to propagate properties but maybe it got lost in a rebase. Will fix.

[danielnorberg]

Found it: #105

[labianchin]

Great!

Still, there can be the case of System properties being configured outside of the command line e.g. with System.getProperties().setProperty(). Maybe we don't have to fix for that, but at least acknowledge the limitation in the documentation. WDYT?

[danielnorberg]

Maybe system properties and env vars is something that should be configurable per task? Or maybe it’s something that could/should be doable using a task context.