Skip to content
This repository was archived by the owner on Aug 31, 2022. It is now read-only.

Conversation

@danielnorberg
Copy link
Contributor

@danielnorberg danielnorberg commented Nov 30, 2018

Hey, I just made a Pull Request!

Description

only run missinglink on CI

Motivation and Context

Make local builds & development faster.

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@danielnorberg danielnorberg requested a review from honnix November 30, 2018 07:26
@danielnorberg danielnorberg changed the title only run missinglink on CI and release only run missinglink on CI Nov 30, 2018
@danielnorberg danielnorberg force-pushed the run-missinglink-on-ci-and-release branch from 18513a6 to ac432c0 Compare November 30, 2018 07:29
@NatashaL
Copy link
Contributor

👍

@danielnorberg danielnorberg merged commit fd5d331 into master Dec 3, 2018
@danielnorberg danielnorberg deleted the run-missinglink-on-ci-and-release branch December 3, 2018 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants