feat: add organisation app installation functionality #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
============================================
+ Coverage 75.10% 75.61% +0.51%
- Complexity 275 279 +4
============================================
Files 42 42
Lines 960 968 +8
Branches 42 42
============================================
+ Hits 721 732 +11
+ Misses 213 211 -2
+ Partials 26 25 -1
|
annelled
reviewed
Jul 31, 2023
| * @return a list of Installation | ||
| */ | ||
| public CompletableFuture<Installation> getInstallation() { | ||
| return maybeRepo.map(repo-> github.request( |
Contributor
There was a problem hiding this comment.
minor: you could extract the inner logic to another method e.g getRepoInstallation.
Abhi347
reviewed
Jul 31, 2023
src/main/java/com/spotify/github/v3/clients/GithubAppClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/spotify/github/v3/clients/GithubAppClient.java
Outdated
Show resolved
Hide resolved
annelled
reviewed
Jul 31, 2023
annelled
reviewed
Jul 31, 2023
annelled
previously approved these changes
Jul 31, 2023
annelled
reviewed
Jul 31, 2023
src/main/java/com/spotify/github/v3/clients/GithubAppClient.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to instantiate the GitHubAppClient from the OrganisationClient
Updates the getInstallation() function to support getting the installations at an organisation level
How to test?
Unit tests have been updated to reflect these changes