Skip to content

Conversation

@miwurster
Copy link
Contributor

Hi, this PR adds support to get the an installation's information using the installation id. Essentially, it enables to use the /app/installations/{installation_id} API endpoint.

@ebk45
Copy link
Contributor

ebk45 commented Dec 22, 2023

Hi @miwurster.

We apologise for taking so long to get eyes on this PR, we haven't been able to maintain this library to the standard we would have liked to but this will be changing in the new year. If you could please get this rebased and we'll be prioritising all open PRs ready for review.

Thanks!

Ellie

@codecov
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24b73da) 76.64% compared to head (331bf5c) 76.69%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
+ Coverage     76.64%   76.69%   +0.04%     
- Complexity      289      290       +1     
============================================
  Files            42       42              
  Lines           989      991       +2     
  Branches         43       43              
============================================
+ Hits            758      760       +2     
  Misses          206      206              
  Partials         25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miwurster
Copy link
Contributor Author

Rebased and ready for review.

Copy link
Contributor

@felix-seifert felix-seifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear and concise contribution. 👍

At first sight, I just had to think about what happens if calling the URL results in not finding the installation or gives another bad response. I then saw that this is handled in our GitHubClient and does not have to be tested several times.

@felix-seifert felix-seifert merged commit 97a1fc1 into spotify:master Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants