Skip to content

Conversation

@felix-seifert
Copy link
Contributor

For using git describe and retrieving a successful result, the Git history including the tags has to be present. The issue is that actions/checkout performs a shallow clone of the depth 1, i.e. a clone without history.

In our case, we might only require the history with tags from HEAD until the currently checked-out commit. As this library's history is not the biggest and we currently do not observe performance issues, I decided to not perform a premature optimisation and just check out the whole Git history with tags.

@felix-seifert felix-seifert requested a review from a team January 11, 2024 08:12
@codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f9f93b) 77.03% compared to head (328995e) 77.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #175   +/-   ##
=========================================
  Coverage     77.03%   77.03%           
  Complexity      305      305           
=========================================
  Files            43       43           
  Lines          1019     1019           
  Branches         44       44           
=========================================
  Hits            785      785           
  Misses          209      209           
  Partials         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dennisgranath dennisgranath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felix-seifert felix-seifert merged commit 8a6c937 into master Jan 11, 2024
@felix-seifert felix-seifert deleted the felixs/fetch-depth branch January 11, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants