Add resumeWithoutException to CircuitBreakerFilter#2082
Merged
ryanjbaxter merged 1 commit intospring-cloud:mainfrom Jun 1, 2021
Merged
Add resumeWithoutException to CircuitBreakerFilter#2082ryanjbaxter merged 1 commit intospring-cloud:mainfrom
ryanjbaxter merged 1 commit intospring-cloud:mainfrom
Conversation
Contributor
dlsrb6342
commented
Dec 17, 2020
dlsrb6342
commented
- Fixes Response body can be modified because of SpringCloudCircuitBreakerFilterFactory #2047
- Resume without exception when CircuitBreaker throw exceptions.
dlsrb6342
force-pushed
the
issue-2047
branch
from
d814a63 to
1390eea
Compare
Codecov Report
@@ Coverage Diff @@
## master #2082 +/- ##
=========================================
Coverage 77.16% 77.16%
- Complexity 1274 1276 +2
=========================================
Files 164 164
Lines 4895 4901 +6
Branches 402 403 +1
=========================================
+ Hits 3777 3782 +5
- Misses 909 910 +1
Partials 209 209
Continue to review full report at Codecov.
|
spencergibb
reviewed
Mar 31, 2021
...org/springframework/cloud/gateway/filter/factory/SpringCloudCircuitBreakerFilterFactory.java
Show resolved
Hide resolved
ryanjbaxter
approved these changes
Apr 5, 2021
Contributor
Author
|
Hi @spencergibb |
spencergibb
approved these changes
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.