Add support for repeatable annotations#1670
Add support for repeatable annotations#1670YangSiJun528 wants to merge 28 commits intospring-io:mainfrom
Conversation
|
Hello! The build is failing because of formatting violations. You can check them locally by running |
|
I made the fix and confirmed it works locally. |
|
Hello, thanks for the PR! I might have missed something here, but why did you create a second implementation for the annotations? Is there a reason we couldn't add the functionality for repeated annotations into the |
This comment was marked as resolved.
This comment was marked as resolved.
|
After thinking more about your previous comment, I realized there might be a better approach that allows You can see it in this commit — I've confirmed that it doesn't break any existing tests: Sorry if my earlier proposal ended up taking unnecessary time. Do you think this approach would be better? |
|
Yes, please update the PR. Thanks! |
|
I've updated the PR. @mhalbritter |
...izr-generator/src/main/java/io/spring/initializr/generator/language/AnnotationContainer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
See gh-1670 Signed-off-by: sijun-yang <yangsijun5528@gmail.com> Co-authored-by: Moritz Halbritter <moritz.halbritter@broadcom.com>
|
Thanks a lot @YangSiJun528 ! |
Resolves issue #1624 by adding support for repeatable annotations of the same type.
Key changes:
AnnotationContainer#addand replaces it withAnnotationContainer#addSingleandAnnotationContainer#customizeSingleAnnotationContainer#addSinglehandles adding single annotationsAnnotationContainer#customizeSinglehandles customizing single annotationsAnnotationContainer#addRepeatableto support repeatable annotationsKotlinSourceCodeWriter#writePropertyto correctly write annotationsAnnotationContainer#addFixes gh-1624