Skip to content

Fix: Initialize TokenTextSplitter Builder fields with default values #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChoHadam wants to merge 1 commit into from
Closed

Fix: Initialize TokenTextSplitter Builder fields with default values #3167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...-commons/src/main/java/org/springframework/ai/transformer/splitter/TokenTextSplitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,15 @@ private String decodeTokens(List<Integer> tokens) {

public static final class Builder {

private int chunkSize;
private int chunkSize = DEFAULT_CHUNK_SIZE;

private int minChunkSizeChars;
private int minChunkSizeChars = MIN_CHUNK_SIZE_CHARS;

private int minChunkLengthToEmbed;
private int minChunkLengthToEmbed = MIN_CHUNK_LENGTH_TO_EMBED;

private int maxNumChunks;
private int maxNumChunks = MAX_NUM_CHUNKS;

private boolean keepSeparator;
private boolean keepSeparator = KEEP_SEPARATOR;

private Builder() {
}
Expand Down