[S1132] Equals avoids null: `org.springframework.boot.openrewrite.SanityCheck`

[Pankraz76]

[S1132] Equals avoids null: org.springframework.boot.openrewrite.SanityCheck

Im wondering if all the null away effort also benefits from using common checks but seems not to be activated like like done in junit as reference:

• https://sonarsource.github.io/rspec/#/rspec/S1132
  • https://checkstyle.sourceforge.io/checks/coding/equalsavoidnull.html
  • https://docs.openrewrite.org/recipes/staticanalysis/equalsavoidsnull

• Avoid potential NPEs for String.equals() calls

• Enable Checkstyle rules to increase consistency junit-team/junit-framework#4748

Somehow the build is not working on my system, the plugin was executed only in buildSrc as this was working.

Thanks.

• [S1132] Fix NPE add org.springframework.boot.openrewrite.SanityCheck#EqualsAvoidsNull #48530 Pankraz76/spring-boot#2

Main branch not compiling, despite java 25.

7: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test-support:spring-boot-test-support:compileJava'.
> Compilation failed; see the compiler output below.
==============================================================================

BUILD FAILED in 43s
1379 actionable tasks: 1357 executed, 1 from cache, 21 up-to-date
➜  spring-boot git:(fix-npe) ./gradlew  clean assemble  
^R                                                                                                                                                                                                                                       
➜  spring-boot git:(fix-npe) java -version
openjdk version "25.0.1" 2025-10-21
OpenJDK Runtime Environment Homebrew (build 25.0.1)
OpenJDK 64-Bit Server VM Homebrew (build 25.0.1, mixed mode, sharing)
➜  spring-boot git:(fix-npe) 

Starting a Gradle Daemon, 2 busy and 4 stopped Daemons could not be reused, use --status for details

> Task :core:spring-boot-autoconfigure-processor:compileJava
/Users/vincent.potucek/IdeaProjects/spring-boot/core/spring-boot-autoconfigure-processor/src/main/java/org/springframework/boot/autoconfigureprocessor/Elements.java:29: error: An unhandled exception was thrown by the Error Prone static analysis plugin.
final class Elements {
      ^
     Please report this at https://github.com/google/error-prone/issues/new and include the following:
  
     error-prone version: 2.42.0
     BugPattern: NullAway
     Stack Trace:
     java.lang.IllegalStateException: Running NullAway in JSpecify mode requires either JDK 22+ or passing the flag -XDaddTypeAnnotationsToSymbol=true to an older JDK that supports it; see https://github.com/uber/NullAway/wiki/JSpecify-Support#supported-jdk-versions for details.
        at com.uber.nullaway.NullAway.matchClass(NullAway.java:1717)
        at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:509)
        at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:618)
        at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:170)
        at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:860)
        at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86)
        at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
        at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
        at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:111)
        at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:119)
        at jdk.compiler/com.sun.source.util.TreeScanner.visitCompilationUnit(TreeScanner.java:152)
        at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:631)
        at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:170)
        at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:614)
        at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:60)
        at com.google.errorprone.scanner.Scanner.scan(Scanner.java:58)
        at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43)
        at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:231)
        at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
        at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1397)
        at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1344)
        at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:933)
        at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
        at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.invocationHelper(JavacTaskImpl.java:152)
        at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
        at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
        at org.gradle.internal.compiler.java.IncrementalCompileTask.call(IncrementalCompileTask.java:92)
        at org.gradle.api.internal.tasks.compile.AnnotationProcessingCompileTask.call(AnnotationProcessingCompileTask.java:94)
        at org.gradle.api.internal.tasks.compile.ResourceCleaningCompilationTask.call(ResourceCleaningCompilationTask.java:57)
        at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:83)
        at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:50)
        at org.gradle.api.internal.tasks.compile.daemon.AbstractIsolatedCompilerWorkerExecutor$CompilerWorkAction.execute(AbstractIsolatedCompilerWorkerExecutor.java:79)
        at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:68)
        at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:54)
        at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:48)
        at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:100)
        at org.gradle.workers.internal.AbstractClassLoaderWorker.executeInClassLoader(AbstractClassLoaderWorker.java:48)
        at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:32)
        at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:22)
        at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:109)
        at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:78)
        at org.gradle.process.internal.worker.request.WorkerAction.lambda$run$1(WorkerAction.java:150)
        at org.gradle.process.internal.worker.child.WorkerLogEventListener.withWorkerLoggingProtocol(WorkerLogEventListener.java:41)
        at org.gradle.process.internal.worker.request.WorkerAction.lambda$run$2(WorkerAction.java:150)
        at org.gradle.internal.operations.CurrentBuildOperationRef.with(CurrentBuildOperationRef.java:84)
        at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:142)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:569)
        at org.gradle.internal.dispatch.MethodInvocation.invokeOn(MethodInvocation.java:77)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:28)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:19)
        at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
        at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
        at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
        at org.gradle.internal.concurrent.AbstractManagedExecutor$1.run(AbstractManagedExecutor.java:47)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:840)
1 error

> Task :core:spring-boot-autoconfigure-processor:compileJava FAILED

[wilkinsona]

NullAway uses the runtime version to check that the required version of Java is being used. The output above shows the Java version after the build failed but doesn't show the version that was used for the build. I suspect that they must be different. You could use --scan to produce a build scan that will provide more information about the Java version that was being used.

[Pankraz76]

Thanks, like this?

https://gradle.com/s/7t73zxlulzxts

Microsoft OpenJDK 64-Bit Server VM 17.0.16+8-LTS (mixed mode, sharing)

yes but having removed all the other jdks now

/opt/homebrew/opt/openjdk/bin/java
/opt/homebrew/opt/openjdk/bin/java
/opt/homebrew/opt/openjdk/bin/java
/opt/homebrew/opt/openjdk/bin/java
/usr/bin/java

➜ spring-boot git:(fix-npe) /usr/bin/java --version
openjdk 17.0.16 2025-07-15 LTS

yes need to delete this bad guy. thanks

[wilkinsona]

Yes, that's right. It shows that you're using Java 17. The Gradle documentation describes how it finds the JDK that it uses. Beyond that, there's nothing that we can do here as this is a setup problem on your machine and out of our control.

[Pankraz76]

yes thanks for the update i could fix this.

What about the actual issue dealing with NPE?

It this nothing good for spring to consider?

[wilkinsona]

I guess you're referring to the changes in https://github.com/Pankraz76/spring-boot/pull/2/changes? Generally speaking, we prefer not to reverse equals checks like has been done there.