Add missing attributes to FilterRegistration annotation#45005
Closed
kwondh5217 wants to merge 7 commits intospring-projects:mainfrom
Closed
Add missing attributes to FilterRegistration annotation#45005kwondh5217 wants to merge 7 commits intospring-projects:mainfrom
kwondh5217 wants to merge 7 commits intospring-projects:mainfrom
Conversation
Signed-off-by: Daeho Kwon <trewq231@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
added
type: enhancement
mhalbritter
changed the title
initParameters and servletRegistrationBeans to @FilterRegistration
mhalbritter
reviewed
Apr 7, 2025
nosan
reviewed
Apr 7, 2025
nosan
reviewed
Apr 7, 2025
Contributor
nosan
left a comment
nosan
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks, @kwondh5217
Signed-off-by: Daeho Kwon <trewq231@naver.com>
Signed-off-by: Daeho Kwon <trewq231@naver.com>
mhalbritter
pushed a commit
that referenced
this pull request
Apr 10, 2025
mhalbritter
added a commit
that referenced
this pull request
Apr 10, 2025
Contributor
|
Thanks @kwondh5217 ! |
Contributor
|
And thanks @nosan for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-45000