Revise "Use Liquibase for test-only migrations" section in reference manual#48169
Revise "Use Liquibase for test-only migrations" section in reference manual#48169vpavic wants to merge 1 commit intospring-projects:3.5.xfrom
Conversation
snicoll
left a comment
There was a problem hiding this comment.
While I agree that it is a good idea to link to official materials rather than explaining third-party features in our own doc, I find the change a bit rough. If you understand liquibase, as well as how to use it in Spring Boot, then you can patch things up and understand how to use it.
However, for a newcomer, you need to map what's described in the liquibase doc to what you'd do in a Spring Boot app (if you wish to). Have you considered keeping the SB-related bits as short as possible and then refer to the doc + blog posts?
I would expect this to be the case, because if you're seeking guidance about test-only migrations using a specific library for DB migration, it means you already know how to use it in Spring Boot? But I do understand that this PR replaces a lot of something with some fairly minimal content consisting of external references. I'll take a look tomorrow into what would be a minimal example of connecting the dots between those external references and something that would be a domain of Spring Boot based application. |
I suppose so but assumptions like that are a bad idea. We need to strike a good balance between repeating ourselves and guiding users to link external content and how it can be used by the project.
That's exactly what I am asking, so thanks for that! |
…manual Closes spring-projectsgh-39539 Signed-off-by: Vedran Pavic <vedran@vedranpavic.com>
|
I've added something that should qualify as a minimal example of connecting the dots between those external references and something that would be a domain of Spring Boot based application. |
See gh-48169 Signed-off-by: Vedran Pavic <vedran@vedranpavic.com>
|
Thanks @vpavic. |
Closes gh-39539