Annotations like @Ssl don't work on @Bean methods when using @ServiceConnection#50033
Closed
kwondh5217 wants to merge 0 commit intospring-projects:3.5.xfrom
Closed
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
kwondh5217
force-pushed
the
fix/50011-service-connection-bean-method-annotations
branch
from
e9e911c to
fd684d2
Compare
philwebb
added
type: bug
philwebb
force-pushed
the
fix/50011-service-connection-bean-method-annotations
branch
from
fd684d2 to
ffabe11
Compare
philwebb
pushed a commit
to kwondh5217/spring-boot
that referenced
this pull request
Apr 13, 2026
Update `ServiceConnectionAutoConfigurationRegistrar` to include annotations from `@Bean` methods. See spring-projectsgh-50033 Signed-off-by: Daeho Kwon <trewq231@naver.com>
philwebb
added a commit
to kwondh5217/spring-boot
that referenced
this pull request
Apr 13, 2026
philwebb
changed the title
philwebb
added a commit
that referenced
this pull request
Apr 13, 2026
philwebb
added a commit
that referenced
this pull request
Apr 13, 2026
Member
|
Thanks very much @kwondh5217. I've tweaked the fix a bit in d3c8829 to make use of |
philwebb
force-pushed
the
fix/50011-service-connection-bean-method-annotations
branch
from
ffabe11 to
208d750
Compare
kwondh5217
deleted the
fix/50011-service-connection-bean-method-annotations
branch
Contributor
Author
|
Thanks @philwebb ! looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, annotations such as
@Sslplaced on@Beanmethods were notdetected when using
@ServiceConnection, becauseServiceConnectionAutoConfigurationRegistraronly read annotations fromTestcontainerBeanDefinitioninstances and passed null for regular@Beanmethod beans.
This commit fixes the issue by reading annotations from the resolved
factory method of the
RootBeanDefinitionwhen the bean is not aTestcontainerBeanDefinition.Closes gh-50011