GH-7646: Additional Kafka Properties #7672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#7646 Add `max.poll.records` and generic `properties.*`.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
Since kafka properties are generally dotted, add a test to ensure dotted "catch-all" properties work.
artembilan
suggested changes
Dec 16, 2016
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Minor concern in Docs.
Otherwise LGTM
| Map<String, Object> producerProperties = properties.buildProducerProperties(); | ||
| producerProperties.put("some.property", "some.value"); | ||
| return new DefaultKafkaProducerFactory<Object, Object>(producerProperties); | ||
| } |
Member
There was a problem hiding this comment.
I think this sample should be still here, although re-phrased.
There are some cases which aren't covered with the current KafkaProperties , (e.g. CommonClientConfigs.METRIC_REPORTER_CLASSES_CONFIG), but I definitely may be interested in different values for consumer and for producer respectively.
Member
There was a problem hiding this comment.
Can we put this code in a file in https://github.com/spring-projects/spring-boot/tree/master/spring-boot-docs/src/main/java/org/springframework/boot and then include it in the docs please? This commit provides an example.
Contributor
Author
There was a problem hiding this comment.
Sweet - will do 😄
Add back custom config example, using include.
philwebb
pushed a commit
that referenced
this pull request
Dec 21, 2016
Add support for arbitrary Kafka properties via `spring.kafka.properties.*` and also a `spring.kafka.max.poll.records` property. See gh-7672
philwebb
added a commit
that referenced
this pull request
Dec 21, 2016
* pr/7672: Polish Kafka properties Support arbitrary Kafka properties
garyrussell
added a commit
to garyrussell/spring-boot
that referenced
this pull request
Jul 17, 2017
PR spring-projects#7672 Added support for arbitrary common properties. However, Kafka emits a warning if a producer configuration contains properties intended only for consumers, and vice versa. The documentation showed a sample of how to write code to configure arbitrary properties but this is inconvenient. Add arbitrary properties to the consumer and procucer configs.
snicoll
pushed a commit
that referenced
this pull request
Jul 19, 2017
PR #7672 Added support for arbitrary common properties. However, Kafka emits a warning if a producer configuration contains properties intended only for consumers, and vice versa. The documentation showed a sample of how to write code to configure arbitrary properties but this is inconvenient. Add arbitrary properties to the consumer and procucer configs. See gh-9775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7646
Add
max.poll.recordsand genericproperties.*.