@Modifying clearAutomatically default value is true [DATAJPA-31]

[spring-projects-issues]

Dragan Gajic opened DATAJPA-31 and commented

The default value of clearAutomatically element of @Modifying is true, which result in clearing persistent context after execution of query. If this modifying query is part of sequence of other update operations, for example when in the service layer we combine calls to several DAOs, clearing persistent context by default can lead to unexpected results. Since the service layer methods are usually bounded by transaction, which end is trigger for synchronization all update operations (merge) before modifying query may be loss because of the cleared persistence context.

I believe this is not uncommon situation, so in that sense maybe it is more appropriate to have this option as false by default.

---

Affects: 1.0 M1

Referenced from: commits 762e57c

[spring-projects-issues]

Oliver Drotbohm commented

Changed the default value to false. Although I think that most use cases involving @Modifying will use the flag set to true I think you're right that the former default had quite extensive consequences that a developer should be aware of. As I don't think documentation can do this to the extend necessary I think a more conservative approach is the way to go