BeanDefinitionRegistryPostProcessor registered via @Bean will not be invoked [SPR-7868]

[spring-projects-issues]

Henryk Konsek opened SPR-7868 and commented

I created simple bean implementing BeanDefinitionRegistryPostProcessor. All I want to do is to register some bean definition in the BeanDefinitionRegistryPostProcessor#postProcessBeanDefinitionRegistry method. The problem is that code working with ClassPathXmlApplicationContext doesn't work with AnnotationConfigApplicationContext.

My intelligent guess would be that BeanDefinitionRegistryPostProcessor#postProcessBeanDefinitionRegistry is called after JavaConfig bean postprocessor.

I'm attaching minimal Maven project with two unit tests (XmlTest & AnnotationTest) to demonstrate the issue.

---

Affects: 3.0.5

Attachments:

• registryBug.zip (23.00 kB)

Issue Links:

• Method postProcessBeanDefinitionRegistry is not called if the bean implements BeanDefinitionRegistryPostProcessor [SPR-9464] #14099 Method postProcessBeanDefinitionRegistry is not called if the bean implements BeanDefinitionRegistryPostProcessor ("is duplicated by")
• BeanFactoryPostProcessor breaks default post-processing of @Configuration classes [SPR-8269] #12917 BeanFactoryPostProcessor breaks default post-processing of @Configuration classes
• Allow BeanDefinitionRegistryPostProcessor to register other BeanDefinitionRegistryPostProcessors [SPR-10630] #15258 Allow BeanDefinitionRegistryPostProcessor to register other BeanDefinitionRegistryPostProcessors

[spring-projects-issues]

Chris Beams commented

Behavior Confirmed. Notice that RegisteringBean#postProcessBeanFactory is called, but #postProcessBeanDefinitionRegistry is not.

Good catch, thanks for filing the issue!

[spring-projects-issues]

Chris Beams commented

Topic branch: https://github.com/cbeams/spring-framework/commits/SPR-7868. An early fix is there, but will need refinement.

[spring-projects-issues]

Chris Beams commented

This is a fundamental limitation of the @Configuration / @Bean approach. Because @Configuration classes are actually themselves processed by a BeanDefinitionRegistryPostProcessor, they cannot in turn register additional BeanDefinitionRegistryPostProcessors. -As a workaround you could register your BDRPP via XML and use @ImportResource, or perhaps more preferably, register it against the application context directly using AnnotationConfigApplicationContext#register(...)- See comment thread on #14099 for further explanation, workarounds and suggestions specific to MyBatis.

[spring-projects-issues]

Jarle Søberg commented

A possible work-around for this issue is to implement BeanDefinitionRegistryPostProcessor and PriorityOrdered as part of the definition of the Configuration:

@Configuration
public class A implements BeanDefinitionRegistryPostProcessor, PriorityOrdered {

    @Override
    public void postProcessBeanDefinitionRegistry(...) {
         ...
    }

    @Override
    public void postProcessBeanFactory(...) {
        ...
    }

    @Override
    public int getOrder() {
        return 0;
    }
}