Allow AnnotationTypeFilter to consider interfaces as well [SPR-8336]

[spring-projects-issues]

Oliver Drotbohm opened SPR-8336 and commented

Currently AnnotationTypeFilter invokes the constructor of AbstractTypeHierarchyTraversingFilter setting considerInterfaces to false. This probably makes sense in most cases. However there might be BeanDefinitionParser implementations that declare a FactoryBean creating a proxy for discovered interfaces. So it would be cool if we could add a constructor to pass in a boolean to enable interface discovery as well.

---

Affects: 3.0.5, 3.1 M1

Attachments:

• filter.patch (3.38 kB)
• mylyn-context.zip (1.26 kB)

Issue Links:

• DATACMNS-37 Support annotation based declaration of repository interfaces ("depends on")
• Metadata reading should never use ASM for java.* and javax.* types (in particular on JDK 8) [SPR-11719] #16341 Metadata reading should never use ASM for java.* and javax.* types (in particular on JDK 8)

Referenced from: commits spring-projects/spring-data-commons@4a70506

[spring-projects-issues]

Oliver Drotbohm commented

Added patch for review. Have that commited locally so that I could push it as is.

[spring-projects-issues]

Oliver Drotbohm commented

Applied the path with slight polishment (removed the invalid comment from the test case) as it was reviewed by Chris. Would be cool if we could backport it to 3.0.6 even if it's no bugfix in a strict sense. I am unsure currently when Spring Data will be able to move to 3.1, as requiring the new major version will probably make Spring Data adoption a bit harder.

[spring-projects-issues]

Oliver Drotbohm commented

• duplicate comment -