MapToMapConverter cannot distinguish MultiValueMap in target [SPR-9499]

[spring-projects-issues]

Dave Syer opened SPR-9499 and commented

It seems that MapToMapConverter cannot distinguish MultiValueMap in target, so it, or one of its converter helpers, will use add() and pass in a List to a map value (which is a List itself) instead of using addAll() (or the equivalent).

---

Affects: 3.1.1

Issue Links:

• Introduce ResolvableType Class [SPR-10973] #15601 Introduce ResolvableType Class ("depends on")
• Provider<...> declaration for @Value method argument fails with TypeMismatchException [SPR-12297] #16903 Provider<...> declaration for @Value method argument fails with TypeMismatchException
• TypeDescriptor can no longer be programatically created with null generics [SPR-11006] #15634 TypeDescriptor can no longer be programatically created with null generics

[spring-projects-issues]

Gary Russell commented

Hi Phil,

I am wondering if this was intentional, but TypeDescriptor.map() previously allowed null arguments in keyTypeDescriptor and valueTypeDescriptor.

We have a test case in SI that is now broken. I don't recall the details, but I believe we added the test as a result of an issue in where conversion is attempted but the generic type information is not available.

I think it was because the situation that Dave reported (conversion when we don't have type information).

It is not clear to me whether we should remove the test (because this fixes the root cause) or whether the method should still work with null descriptors

https://jira.springsource.org/browse/INT-2955

Thanks

[spring-projects-issues]

Phil Webb commented

Gary Russell That's an oversight on my part, see #15634

[spring-projects-issues]

Gary Russell commented

cool; thanks