Read large data using InputStreamResource at ResourceHttpMessageConverter [SPR-13443]

[spring-projects-issues]

Kazuki Shimizu opened SPR-13443 and commented

Currently,ResourceMessageConverter is reading as ByteArrayResource from the HTTP body. If large data has been set at http body, there is possibility that occur the OutOfMemoryError.

I want to be able to read as InputStreamResource as follows:

RestTemplate restTemplate = new RestTemplate();
Resource resource = restTemplate.getForObject("http://localhost:8080/myApp/foo.zip", InputStreamResource.class);

How do think ?
I submit a PR at the later.

---

Affects: 4.2.1

Issue Links:

• RestTemplate with InputStreamResource does not work if Content-Length is not set [SPR-12017] #16633 RestTemplate with InputStreamResource does not work if Content-Length is not set
• resttemplate multipart post with InputStreamResource not working [SPR-13571] #18147 resttemplate multipart post with InputStreamResource not working
• Consistent throwing of HttpMessageNotReadableException in HttpMessageConverter implementations [SPR-16995] #21533 Consistent throwing of HttpMessageNotReadableException in HttpMessageConverter implementations

Referenced from: pull request #871, and commits 1feb757

[spring-projects-issues]

Kazuki Shimizu commented

I've submit a PR.
Please check it.

[spring-projects-issues]

Juergen Hoeller commented

Good idea! Added in a slightly revised fashion now, also checking whether we support the specified resource class at all.

Juergen

[spring-projects-issues]

Kazuki Shimizu commented

Hi Juergen,

Thanks for polishing and merging!! i happy :)

[spring-projects-issues]

Mauro Molinari commented

But does this work as expected? Isn't the input stream already closed after the call to getForObject has ended?
See also #12015 and https://stackoverflow.com/a/48041200/1465635