Upgrade build to Gradle 2.14.1 [SPR-14362]

[spring-projects-issues]

Sam Brannen opened SPR-14362 and commented

• Upgrade the build to Gradle 2.14 once master has been switched to 5.0.
• Upgrade the build to Gradle 2.14.1 once it has been released.
  • Current Gradle release candidate page
  • Gradle 2.14.1-rc-1 was released on June 29th, 2016.
  • Gradle 2.14.1-rc-2 is available as of July 11th, 2016.
  • Gradle 2.14.1 was released on July 18th, 2016.

---

Issue Links:

• Upgrade 4.3.x build to Gradle 2.14.x [SPR-14570] #19139 Upgrade 4.3.x build to Gradle 2.14.x ("is depended on by")
• ReflectionTestUtils.setField() should not call toString() on the target [SPR-9571] #14205 ReflectionTestUtils.setField() should not call toString() on the target
• Upgrade build to Gradle 2.13 [SPR-14215] #18789 Upgrade build to Gradle 2.13
• Upgrade build to Gradle 3.0 [SPR-14569] #19138 Upgrade build to Gradle 3.0
• ReflectionTestUtils should defensively invoke toString() on target objects [SPR-14363] #18935 ReflectionTestUtils should defensively invoke toString() on target objects

[spring-projects-issues]

Sam Brannen commented

Resolved in GitHub commit 2fd4462:

Upgrade build to Gradle 2.14

In the process of upgrading the build to use Gradle 2.14, the
setFieldOnLegacyEntityWithSideEffectsInToString() test method in
ReflectionTestUtilsTests began to fail. The reason is that the log
level for ReflectionTestUtils is now DEBUG by default with Gradle 2.14.
The apparent cause is that log4j was present on the test runtime
classpath for the spring-test module with all previous versions of
Gradle (via a transitive optional dependency from another project that
spring-test depends on). Thus the configuration in log4j.properties in
spring-test was previously honored, but with Gradle 2.14 a different
commons logging implementation is picked up.

Thus, in addition to upgrading the build to Gradle 2.14, this commit
introduces an explicit test runtime dependency on log4j in the
spring-test module.

The discovered bug in ReflectionTestUtils regarding DEBUG log level
will be addressed separately.

[spring-projects-issues]

Stéphane Nicoll commented

I think we had that conversation before. 4.3 GA is out and I'd like we avoid to upgrade aggressively the build infrastructure. We can obviously resume this once master becomes 5.0 SNAP

[spring-projects-issues]

Sam Brannen commented

OK. I'll revert the change in master and assign this issue to 5.0 M1.

[spring-projects-issues]

Juergen Hoeller commented

Gradle 2.14 seems to be the end of the 2.x line, so generally worth upgrading to in the 4.3.x line... at some point at least.

[spring-projects-issues]

Stéphane Nicoll commented

Given the extensive maintenance period of 4.3 I agree but I am not keen on doing this right now. Especially with regards to the upcoming 4.3.1.RELEASE.