getBeanNamesForType(ResolvableType) doesn't match generic factory method return type for yet-to-be-created bean [SPR-15011]

[spring-projects-issues]

Phil Webb opened SPR-15011 and commented

Originally raised as a @SpyBean issue with Spring Boot. When calling beanFactory.getBeanNamesForType from a BeanFactoryPostProcessor the predictBeanType method does not consider generics. This means given a bean definition Foo<String> calling ResolvableType.forClassWithGenerics(Foo.class, String.class) will not work.

Here's a minimal test case:

import static org.junit.Assert.assertTrue;

import org.junit.Test;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.core.Ordered;
import org.springframework.core.ResolvableType;
import org.springframework.core.annotation.Order;

public class GenericBeanTests {

	@Test
	public void test() {
		AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext();
		context.register(Config.class);
		context.register(TestPostProcessor.class);
		context.refresh();
		context.close();
	}

	@Order(Ordered.LOWEST_PRECEDENCE)
	public static class TestPostProcessor implements BeanFactoryPostProcessor {

		@Override
		public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException {
			assertTrue(beanFactory.getBeanNamesForType(Foo.class).length > 0);
			assertTrue(beanFactory.getBeanNamesForType(ResolvableType.forClass(Foo.class)).length > 0);
			assertTrue(beanFactory.getBeanNamesForType(ResolvableType.forClassWithGenerics(Foo.class, String.class)).length > 0);
		}

	}

	@Configuration
	public static class Config {

		@Bean
		public Foo<String> fooBean() {
			return new StringFoo();
		}

	}

	public static interface Foo<T> {

	}

	public static class StringFoo implements Foo<String> {

	}

}

---

Affects: 4.3.4

Issue Links:

• ListableBeanFactory#getBeanNamesForType(ResolvableType) fails to return generic @Bean methods [SPR-14118] #18690 ListableBeanFactory#getBeanNamesForType(ResolvableType) fails to return generic @Bean methods ("is duplicated by")
• Add generics / parameterized type support to ListableBeanFactory getBeanNamesForType/getBeansOfType methods [SPR-12147] #16761 Add generics / parameterized type support to ListableBeanFactory getBeanNamesForType/getBeansOfType methods
• getBeanNamesForType(ResolvableType) does not reliably work for beans with AOP proxies [SPR-14097] #18669 getBeanNamesForType(ResolvableType) does not reliably work for beans with AOP proxies
• Inconsistent getTypeForFactoryMethod results for parameterized factory method [SPR-16720] #21261 Inconsistent getTypeForFactoryMethod results for parameterized factory method
• getBeanNamesForType(ResolvableType) doesn't work for raw singleton instance from @Bean method with generic return type [SPR-17524] #22056 getBeanNamesForType(ResolvableType) doesn't work for raw singleton instance from @Bean method with generic return type
• Provide registerBean variants based on ResolvableType [SPR-15197] #18463 Provide registerBean variants based on ResolvableType

1 votes, 3 watchers

[spring-projects-issues]

Juergen Hoeller commented

I've got this addressed through a ResolvableType-based revision of our factory method return type caching in RootBeanDefinition, with corresponding use of that full type (if available) in the AbstractBeanFactory.isTypeMatch algorithm. RootBeanDefinition.setTargetType(ResolvableType) hints get respects there as well now.

I'll have this backported to 4.3.5 by Monday morning. Let's see what our integration tests say then...