SettableListenableFuture may be both set and canceled successfully [SPR-15202]

[spring-projects-issues]

Ivan Sopov opened SPR-15202 and commented

Please see this jcstress-based test:

https://github.com/isopov/isopov-jcstress/blob/master/src/main/java/com/sopovs/moradanen/jcstress/spring/SettableListenableFutureTest.java

There is no such bug in guava:

https://github.com/isopov/isopov-jcstress/blob/master/src/main/java/com/sopovs/moradanen/jcstress/guava/SettableFutureTest.java

Or in CompletableFuture from JUC:

https://github.com/isopov/isopov-jcstress/blob/master/src/main/java/com/sopovs/moradanen/jcstress/CompletableFutureTest.java

---

Affects: 4.3.6

Issue Links:

• SettableListenableFuture set has a race on Java6 (and old versions of Java7) [SPR-16183] #20731 SettableListenableFuture set has a race on Java6 (and old versions of Java7)
• SettableListenableFuture may be successfully set with failureCallback executed and success callback ignored [SPR-15216] #19781 SettableListenableFuture may be successfully set with failureCallback executed and success callback ignored
• SettableListenableFuture setException is inconsistent with callbacks under race [SPR-15409] #19972 SettableListenableFuture setException is inconsistent with callbacks under race

Referenced from: commits 9666fcc, dec1c93

[spring-projects-issues]

Juergen Hoeller commented

We're consistently obtaining the done/cancelled state from our inner SettableTask now, so that it is guaranteed to be in sync with a value/exception set.