Support for HtmlUnit 2.25+ [SPR-15319]

[spring-projects-issues]

Juergen Hoeller opened SPR-15319 and commented

HtmlUnit 2.25 changed its WebRequest.getCharset() method to return a Charset instead of a String, breaking binary compatibility with our HtmlUnitRequestBuilder.

As of 5.0 RC1, we can simply require HtmlUnit 2.25+ and use the new signature accordingly. In 4.3.8, we can reflectively tolerate both signatures.

---

Issue Links:

• Revisit dependency baseline: Jetty 9.4+, OkHttp 3+ [SPR-15038] #19604 Revisit dependency baseline: Jetty 9.4+, OkHttp 3+

Referenced from: commits 9de9761, e61e8d5

[spring-projects-issues]

Phil Webb commented

Annoying that that's changed in a minor patch release. Any plans for 2.25 support in 4.3.x?

[spring-projects-issues]

Juergen Hoeller commented

Good point, let's tolerate both signatures in 4.3.x for the time being...