AspectJ annotation pointcuts fail to evaluate against interface-based proxies [SPR-16803]

[spring-projects-issues]

Yanming Zhou opened SPR-16803 and commented

If target object is JDK dynamic proxy, Aspectj annotation pointcut match failed since proxy class method lost annotations, here is a simple test

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNotNull;

import java.lang.reflect.Method;

import org.aopalliance.intercept.MethodInterceptor;
import org.aopalliance.intercept.MethodInvocation;
import org.junit.Test;
import org.springframework.aop.framework.ProxyFactory;
import org.springframework.aop.support.AopUtils;
import org.springframework.transaction.annotation.Transactional;

public class AopUtilsTest {

	@Test
	public void getMostSpecificMethod() throws Exception {
		MyInterface proxy = (MyInterface) new ProxyFactory(MyInterface.class, new MyMethodInterceptor())
				.getProxy(MyInterface.class.getClassLoader());
		Method interfaceMethod = MyInterface.class.getMethod("test");
		Method proxyMethod = proxy.getClass().getMethod("test");
		Method mostSpecificMethod = AopUtils.getMostSpecificMethod(interfaceMethod, proxy.getClass());
		assertNotEquals(proxyMethod, interfaceMethod);
		assertEquals(interfaceMethod, mostSpecificMethod); //failed
		assertNotNull(mostSpecificMethod.getAnnotation(Transactional.class));
	}

	public static interface MyInterface {

		@Transactional
		public String test();

	}

	public static class MyMethodInterceptor implements MethodInterceptor {

		@Override
		public Object invoke(MethodInvocation mi) throws Throwable {
			return null;
		}

	}

}

We should add a short-circuit

if(Proxy.isProxyClass(targetClass))
     return method;

I'm not sure this change should apply for AopUtils.getMostSpecificMethod() or ClassUtils.getMostSpecificMethod()

---

Affects: 5.0.6

Attachments:

• spr16803.zip (7.46 kB)

Issue Links:

• AspectJ execution pointcut does not detect methods in superinterface anymore [SPR-16723] #21264 AspectJ execution pointcut does not detect methods in superinterface anymore
• AopUtils.getMostSpecificMethod should expose dynamic proxy class methods [SPR-16757] #21298 AopUtils.getMostSpecificMethod should expose dynamic proxy class methods
• Mixed use BeanNameAutoProxyCreator and AnnotationAwareAspectJAutoProxyCreator to proxy same bean [SPR-16677] #21218 Mixed use BeanNameAutoProxyCreator and AnnotationAwareAspectJAutoProxyCreator to proxy same bean
• Spring 5.x DataSource proxying does not work with Oracle UCP on JDK 9+ [SPR-17003] #21541 Spring 5.x DataSource proxying does not work with Oracle UCP on JDK 9+

Referenced from: commits bba5dca, 416dee7

[spring-projects-issues]

Juergen Hoeller commented

#21298 intentionally restored our original behavior of returning proxy class methods from AopUtils.getMostSpecificMethod, as it was pre 5.0.5. If you're seeing a regression with AspectJ pointcuts there, let's rather try to address this at the AspectJ evaluation level. Could you provide a test case for a corresponding AspectJ pointcut? Did your scenario work against 5.0.4 before or just against 5.0.5, i.e. is this actually a regression against 5.0.4 or just against a 5.0.5 side effect?

[spring-projects-issues]

Yanming Zhou commented

I upload a maven project, It works since 5.0.5, but soon failed with 5.0.6, It's a regression affected by 8b051ab#diff-41acc8f24cd73cb3d6eb62635bfb2938L195

&& !Proxy.isProxyClass(targetClass)
``` is removed.