Replace hardcoded "Sec-WebSocket-Version" with constant#34319
Closed
kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
Closed
Replace hardcoded "Sec-WebSocket-Version" with constant#34319kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: Daeho Kwon <trewq231@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
the
in: web
rstoyanchev
added
type: task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation uses a hardcoded string "Sec-WebSocket-Version" in the method, while also using the constant WebSocketHttpHeaders.SEC_WEBSOCKET_VERSION within the same method. This inconsistency could lead to potential errors during maintenance and reduces code readability.
Modification
Result
This is a purely refactor-level change. No functional behavior has been altered, and existing functionality remains intact.