Support Determining Max Sessions by Authentication#16218
Support Determining Max Sessions by Authentication#16218jzheaux merged 1 commit intospring-projects:mainfrom
Conversation
|
@ClaudenirFreitas Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ClaudenirFreitas Thank you for signing the Contributor License Agreement! |
jzheaux
left a comment
There was a problem hiding this comment.
Thanks for such a quick turnaround, @ClaudenirFreitas! I've left my feedback inline.
thanks a lot, @jzheaux. Meanwhile, I am still working on creating some integration tests to cover the configurations via XML, ok? |
jzheaux
left a comment
There was a problem hiding this comment.
Thanks for the updates, @ClaudenirFreitas! I've left some additional feedback inline.
Let me know when you have integration tests ready, and I'll take another look.
@jzheaux integration tests have been added. Many tests failed due to the new release (6.5). I've updated many files on this commit, and the tests are passing now. Silly question, is this flow correct for the new release? |
@jzheaux |
jzheaux
left a comment
There was a problem hiding this comment.
Just the finishing touches now! Please see my inline feedback.
Also, please squash your commits at this point and format it like so:
Add Max Sessions by Authentication
Closes gh-16206
@jzheaux |
|
Thanks for asking. We don't prefer to add a merge commit to the history in this case. Do you need help squashing? |
@jzheaux Yes, please. |
|
Thanks for all your work on this PR, @ClaudenirFreitas! This is now merged into |
Thanks a lot for the help, @jzheaux! We could add a sample using this config in the |

Closes gh-16206