Fix loader has changed while resolving nodes in WebAuthnWebDriverTests#16463
Closed
Kehrlann wants to merge 1 commit intospring-projects:6.4.xfrom
Closed
Fix loader has changed while resolving nodes in WebAuthnWebDriverTests#16463Kehrlann wants to merge 1 commit intospring-projects:6.4.xfrom
Kehrlann wants to merge 1 commit intospring-projects:6.4.xfrom
Conversation
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Member
|
Thanks for the Pull Request! This is now merged into 6.4.x and main 😄 |
kwondh5217
pushed a commit
to kwondh5217/spring-security
that referenced
this pull request
Feb 4, 2025
Closes spring-projectsgh-16463 Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf> Signed-off-by: Daeho Kwon <trewq231@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reviewer: @rwinch
Context
Test
WebAuthnWebDriverTests.loginWhenNoValidAuthenticatorCredentialsThenRejectshas been flakey ; throwing:The cause as a navigation by the browser during the
getCurrentUrlcall.Fix: allow
awaitto retry when encounteringWebDriverException.