Improve VCDM2 name and description properties support
#674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementation.
timothee-haudebourg
force-pushed
the
improve-vcdm2-name-and-description
branch
from
184e746 to
f01084b
Compare
cobward
approved these changes
Jun 3, 2025
sbihel
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the missing
nameanddescriptionproperties to the credential type, and use the proper trait for thenameproperty in the credential trait. Also get rids of theDescriptiontype parameter (use an existential type instead).Other changes
InternationalStringtrait intoAnyInternationalStringto avoid ambiguities with theInternationalStringtype.AnyInternationalString::get_languagetrait method to query a string in a given language.AnyInternationalStringfor basic types, such asstr.