-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
PR: Set the AppUserModelID to be the same as that used by our menuinst shortcut
#25481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Set the AppUserModelID to be the same as that used by our menuinst shortcut
#25481
Conversation
84b6694 to
27abe37
Compare
AppUserModelID to be the same as that used by our menuinst shortcut
|
@mrclary, is this ready for review? |
|
Yep, ready for review |
ccordoba12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions for you @mrclary.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com> Co-authored-by: Daniel Althviz Moré <16781833+dalthviz@users.noreply.github.com>
1688276 to
3f1ee71
Compare
|
@mrclary, the failures in our tests are due to a new version of I already reported the problem upstream. |
Interesting. Is our caching paradigm not working properly? The |
|
I see. The new |
dalthviz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrclary !
|
I fixed the failure in our tests in PR #25506, so merging. |
|
@meeseeksdev please backport to 6.x |
…same as that used by our menuinst shortcut
…the same as that used by our menuinst shortcut) (#25511)
|
Hello All, Setup (for reference): I don’t know how the final packaging/shortcuts will look in 6.1.3. However, if the shipped Start Menu shortcut AppID is still suffix’d (e.g., |
Description of Changes
set_windows_appusermodelidnow set the AppUserModelID to be the same as that used by ourmenuinstshortcut.For conda-based installations, this is
spyder-ide.Spyder-{major version}. For all other installations this isspyder-ide.Spyder-{major version}.{environment name}.Issue(s) Resolved
Fixes #24292