implement couler codegen #1268
Merged
implement couler codegen #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey0623
force-pushed
the
couler_codegen
branch
from
4c27e9e to
a0a3364
Compare
Yancey0623
requested review from
shendiaomo,
tonyyang-svail,
typhoonzero and
weiguoz
typhoonzero
reviewed
Nov 27, 2019
| } | ||
|
|
||
| // 3. submit Argo YAML and fetch the workflow ID. | ||
| cmd = exec.Command("kubectl", "create", "-f", argoYaml.Name()) |
Collaborator
There was a problem hiding this comment.
can use k8s API here?
Collaborator
Author
There was a problem hiding this comment.
Sure, will import k8s package when implement Fetch gRPC interface, and I will rewrite here to use k8s API.
typhoonzero
previously approved these changes
Nov 28, 2019
| r := &coulerFiller{} | ||
| for _, sqlIR := range programIR { | ||
| ss := &sqlStatment{} | ||
| switch sqlIR.(type) { |
Collaborator
There was a problem hiding this comment.
Maybe we need to update this implement to #1272.
| # TODO(yancey1989): | ||
| # using "repl -parse" to output IR and | ||
| # feed to "sqlflow_submitter.{submitter}.train" to submite the job | ||
| couler.run_container(command='''repl -e "{{ $ss.OriginalSQL }}"''', image="{{ $ss.DockerImage }}") |
Collaborator
There was a problem hiding this comment.
Maybe add env as the session at here.
Collaborator
Author
There was a problem hiding this comment.
You're right, will add it in the next PR.
typhoonzero
approved these changes
Nov 28, 2019
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part work of #1066
TODO: add e2e test for couler mode