Fix 31 todo tests by adding # comment and parameterized query support#23
Merged
kyleconroy merged 2 commits intomainfrom Dec 18, 2025
Merged
Fix 31 todo tests by adding # comment and parameterized query support#23kyleconroy merged 2 commits intomainfrom
kyleconroy merged 2 commits intomainfrom
Conversation
- Add support for # style line comments in lexer (ClickHouse supports both -- and # comments)
- Update parser_test.go to skip lines starting with # when building query
- Add parameterized identifier support ({name:Type} syntax) in parseIdentifierName()
- Remove todo flag from 31 tests that now pass
The parser changes enable:
1. Hash-style single-line comments (# comment text)
2. Parameterized identifiers in table/database names like {CLICKHOUSE_DATABASE:Identifier}
Tests now passing:
- 03524_sign_argument, 03546_leftover_dependencies
- 03310_create_database_with_settings, 03321_create_table_as_replicated_engine_args
- 03442_detach_view, 03267_materialized_view_keeps_security_context
- 03222_ignore_nulls_query_tree_elimination, 03362_create_table_after_truncate_replicated_database
- 03512_join_using_parent_scope_matcher, 02891_rename_table_without_keyword
- And 21 more...
Remaining: 381 todo tests (down from 412)
- Default to ClickHouse v24.8.4.13 stable release - Allow version override via CLICKHOUSE_VERSION environment variable - Add force-download command to re-download with new version - Add version command to show configured and installed versions - Update help text with examples This enables regenerating test expectations consistently by pinning to a specific ClickHouse version. Usage: ./scripts/clickhouse.sh download # Use default version CLICKHOUSE_VERSION=24.3.1.5 ./scripts/clickhouse.sh force-download
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser changes enable:
Tests now passing:
Remaining: 381 todo tests (down from 412)