Fix EXPLAIN AST output for strings with embedded single quotes#34
Merged
kyleconroy merged 1 commit intomainfrom Dec 24, 2025
Merged
Fix EXPLAIN AST output for strings with embedded single quotes#34kyleconroy merged 1 commit intomainfrom
kyleconroy merged 1 commit intomainfrom
Conversation
The escapeStringLiteral function was outputting just `\'` for embedded single quotes, but ClickHouse EXPLAIN AST uses `\\\'` (escaped backslash + escaped quote) for embedded quotes within string literals. This fix aligns with the behavior shown in many existing tests: - 00011_sorting: DateTime(\'Asia/Dubai\') - 00324_hashing_enums: Enum8(\'Hello\' = 0, \'World\' = 1) - 00471_sql_style_quoting: hello\'world - And many others Also fixes test 03404's explain.txt which had incorrect escaping. Enables 4 previously failing tests: - 01434_netloc_fuzz - 03003_sql_json_nonsense - 03521_tuple_of_dynamic_with_string_comparison - 03567_finalize_write_buffer_valid_utf8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The escapeStringLiteral function was outputting just
\'for embeddedsingle quotes, but ClickHouse EXPLAIN AST uses
\\\'(escaped backslashThis fix aligns with the behavior shown in many existing tests:
Also fixes test 03404's explain.txt which had incorrect escaping.
Enables 4 previously failing tests: