Fix unknown escape sequences in string literals to preserve backslash#38
Merged
kyleconroy merged 1 commit intomainfrom Dec 25, 2025
Merged
Fix unknown escape sequences in string literals to preserve backslash#38kyleconroy merged 1 commit intomainfrom
kyleconroy merged 1 commit intomainfrom
Conversation
Previously, when the lexer encountered an unknown escape sequence like \S in a string, it would only write the character after the backslash, losing the backslash itself. This caused strings like 'Win\Sys' to be stored as 'WinSys' instead of 'Win\Sys'. This fix preserves both the backslash and the following character for unknown escape sequences, matching ClickHouse's behavior. Enables 5 passing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when the lexer encountered an unknown escape sequence like
\S in a string, it would only write the character after the backslash,
losing the backslash itself. This caused strings like 'Win\Sys' to be
stored as 'WinSys' instead of 'Win\Sys'.
This fix preserves both the backslash and the following character for
unknown escape sequences, matching ClickHouse's behavior.
Enables 5 passing tests.