Skip to content

Fix 10 parser tests with various EXPLAIN AST improvements#43

Merged
kyleconroy merged 1 commit intomainfrom
claude/fix-failing-tests-8QIo9
Dec 25, 2025
Merged

Fix 10 parser tests with various EXPLAIN AST improvements#43
kyleconroy merged 1 commit intomainfrom
claude/fix-failing-tests-8QIo9

Conversation

@kyleconroy
Copy link
Copy Markdown
Collaborator

Changes:

  • Add scientific notation for very small float literals (< 1e-10)
  • Handle SQL-style doubled quote escapes in identifiers ("hel""lo")
  • Add formatBinaryExprForType for Enum type parameters
  • Handle sumDistinct and other aggregate functions with DISTINCT
  • Add CastExpr handling in explainWithElement for WITH aliases
  • Add window frame offset rendering in WindowDefinition

Tests enabled:

  • 01914_ubsan_quantile_timing (scientific notation)
  • 00471_sql_style_quoting (doubled quote escapes)
  • 00267_tuple_array_access_operators_priority (arrays with tuples)
  • 00726_length_aliases (function name normalization)
  • 00674_has_array_enum (Enum type formatting)
  • 00502_string_concat_with_array (arrays with identifiers)
  • 02158_interval_length_sum (tuples with negative numbers)
  • 00160_decode_xml_component (DISTINCT modifier)
  • 01353_topk_enum (CAST in WITH clause)
  • 02306_window_move_row_number_fix (window frame offset)

Additional tests now pass due to improvements:

  • 00317, 00324, 00511, 00526, 00548, 00566, 00642
  • 01259, 01651, 01700, 01717, 02958, 03003, 03747

Changes:
- Add scientific notation for very small float literals (< 1e-10)
- Handle SQL-style doubled quote escapes in identifiers ("hel""lo")
- Add formatBinaryExprForType for Enum type parameters
- Handle sumDistinct and other aggregate functions with DISTINCT
- Add CastExpr handling in explainWithElement for WITH aliases
- Add window frame offset rendering in WindowDefinition

Tests enabled:
- 01914_ubsan_quantile_timing (scientific notation)
- 00471_sql_style_quoting (doubled quote escapes)
- 00267_tuple_array_access_operators_priority (arrays with tuples)
- 00726_length_aliases (function name normalization)
- 00674_has_array_enum (Enum type formatting)
- 00502_string_concat_with_array (arrays with identifiers)
- 02158_interval_length_sum (tuples with negative numbers)
- 00160_decode_xml_component (DISTINCT modifier)
- 01353_topk_enum (CAST in WITH clause)
- 02306_window_move_row_number_fix (window frame offset)

Additional tests now pass due to improvements:
- 00317, 00324, 00511, 00526, 00548, 00566, 00642
- 01259, 01651, 01700, 01717, 02958, 03003, 03747
@kyleconroy kyleconroy merged commit d82d2e1 into main Dec 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants