Merged
Conversation
kyleconroy
requested changes
Sep 21, 2021
Collaborator
kyleconroy
left a comment
There was a problem hiding this comment.
Can we create mirror what eabuild does and create a new pkg/cli package?
Contributor
Author
|
@kyleconroy sure, I amended my commit. |
kyleconroy
requested changes
Sep 21, 2021
Collaborator
kyleconroy
left a comment
There was a problem hiding this comment.
Can we remove the stdin, stdout, and stderr arguments? I'd like the exposed function to only take a string slice.
Contributor
Author
|
Like this? |
kyleconroy
approved these changes
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #416
This PR adds an exported
Runfunction to the root package.This allows this library to be simply embedded into other cli apps.
Usage is just like https://github.com/kyleconroy/sqlc/blob/main/cmd/sqlc/main.go :
This does not export any internal types, but simply exposes the same interface as the CLI to any go program.
In my case, I have a
toolfolder in my go project with this file, so that I can rungo run ./tool/sqlc.goand be sure to have the right version from the project'sgo.mod