Merged
Conversation
Collect a few commonly used functions and put them into one package. Move the utils.go file from the codegen package here as well.
kyleconroy
commented
Mar 2, 2022
Comment on lines
-6
to
+8
| "github.com/kyleconroy/sqlc/internal/compiler" | ||
| "github.com/kyleconroy/sqlc/internal/codegen/sdk" |
Collaborator
Author
There was a problem hiding this comment.
This was the main point of the change. The Go codegen no longer depends on the compiler or config packages.
Contributor
|
Nice! I am curious what your plan for plugins overall looks like. Is this code going to get pulled outside of Some other loose thoughts:
|
Collaborator
Author
|
I have a whole plan but haven’t written it up in a design doc. Will do tonight and share it here. |
Collaborator
Author
Collaborator
Author
|
It's not well documented, but the SDK package is here: https://github.com/sqlc-dev/plugin-sdk-go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect a few commonly used functions and put them into one package.
Move the utils.go file from the codegen package here as well.
cc @stephen