Pydantic models config field#1538
Merged
kyleconroy merged 3 commits intosqlc-dev:mainfrom Apr 20, 2022
Merged
Conversation
kyleconroy
requested changes
Apr 10, 2022
Collaborator
kyleconroy
left a comment
kyleconroy
left a comment
There was a problem hiding this comment.
Thanks for the first draft. Requested a few changes; let me know if you have any questions.
kyleconroy
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since dataclasses are the default since #939, I added an optional
use_pydantic_modelsfield to use Pydantic for all models (discussed since #923) which requires much less boilerplate later at least for my use case