Skip to content

SQLite SELECT parameters#1686

Closed
russellhaering wants to merge 3 commits intosqlc-dev:mainfrom
russellhaering:improved_sqlite_select
Closed

SQLite SELECT parameters#1686
russellhaering wants to merge 3 commits intosqlc-dev:mainfrom
russellhaering:improved_sqlite_select

Conversation

@russellhaering
Copy link

Experimenting with SQLite and this query wasn't working as intended:

/* name: GetUser :one */
SELECT * FROM users WHERE id = ? LIMIT 1;

This PR adds some code to pass WHERE clauses on SELECT statements through to the internal AST, which seems to resolve the issue - although is no means comprehensive (for example sqlc.arg() still does not work).

@russellhaering
Copy link
Author

Closing this out. #1687 generates identical code, and handles many more use-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant